Make maybe_memory truly optional #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the name implies, it's already optional, but wasn't marked as such in TS. We could put some more complicated / stricter types here depending on type of the first argument, but at least this fixes the issue for TS consumers. Fixes rustwasm#2133
|
Just noticed the issue with passing in ArrayBuffer too; please don't merge yet, fixing it as well. |
It should always be built with nightly, and this file sets the toolchain for Rustup.
- Unify `init_memory` for `maybe_memory` case to use either the explicitly given value or the default (`new WebAssembly.Memory(...)`). - Move it to the main `init` function where all other `imports` are assigned too. - Remove global `memory` variable which doesn't seem to be used by anything.
|
Done. /cc @alexcrichton @Pauan |
RReverser
changed the title
RReverser
commented
Feb 26, 2021
alexcrichton
reviewed
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the name implies, it's already optional, but wasn't marked as such in TS.
We could put some more complicated / stricter types here depending on type of the first argument, but at least this fixes the issue for TS consumers.
Also fixes an issue where
maybe_memorywouldn't be initialised if theinput(module) is given as anArrayBuffer.Fixes #2133